Skip to content

[PWGHF] Dstar spin alignment: Add rotation and extend the MC derived data - #18591

Draft
Mingze129 wants to merge 10 commits into
AliceO2Group:masterfrom
Mingze129:phi_dep_dev
Draft

[PWGHF] Dstar spin alignment: Add rotation and extend the MC derived data#18591
Mingze129 wants to merge 10 commits into
AliceO2Group:masterfrom
Mingze129:phi_dep_dev

Conversation

@Mingze129

@Mingze129 Mingze129 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
  1. Implement rotation angle control for the spin quantization axis and investigate the phi dependence.
  2. Add MC derived-data production for MC closure test for mix-candidate method.

@github-actions github-actions Bot added the pwghf PWG-HF label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 9 disabled

@alibuild alibuild mentioned this pull request Nov 4, 2026
Merged
@Mingze129
Mingze129 marked this pull request as draft November 4, 2026 15:07
@Mingze129
Mingze129 marked this pull request as draft November 4, 2026 15:07
@alibuild alibuild mentioned this pull request Nov 4, 2026
Merged
@Mingze129
Merge pull request #28 from alibuild/alibot-cleanup-18591
28269ff 
Please consider the following formatting changes to AliceO2Group#18591
@Mingze129
Remove unused string header
7497bd5 
Removed unnecessary string include from treeCreatorDstarSpinAlignMixing.cxx
@Mingze129
Include string header in taskCharmPolarisation.cxx
eff8d10 
Added include directive for string header.
@Mingze129
Mingze129 marked this pull request as ready for review November 4, 2026 15:50
@alibuild

alibuild commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for eff8d10 at 2026-11-04 17:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 7 errors and 24 warnings.'
Found 7 errors and 24 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/f294cb0c94ea02da0851f1d051d28a393454522d/O2Physics-code-check/errors.txt
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:152:96: error: no header providing "o2::aod::PVMults" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:207:51: error: no header providing "std::exp" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:214:62: error: no header providing "o2::constants::math::TwoPI" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:217:51: error: no header providing "std::cos" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:246:11: error: variable 'ptBhadMother' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:291:43: error: no header providing "std::sin" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:393:69: error: no header providing "std::sqrt" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/f294cb0c94ea02da0851f1d051d28a393454522d/O2Physics-code-check/warnings.txt
PWGHF/D2H/TableProducer/treeCreatorDstarSpinAlignMixing.cxx:219:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:38: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:54: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:76: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:95: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:120: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:138: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:162: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:183: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:210: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:247: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:269: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:297: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:321: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:351: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:370: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:395: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:314:416: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:323:35: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:323:71: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:323:109: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:323:141: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:323:175: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGHF/D2H/Tasks/taskCharmPolarisation.cxx:934:34: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 7 -gt 0 ]]
++ exit 1
--
[0 more errors; see full log]

Full log here.

@Mingze129
Mingze129 marked this pull request as draft November 4, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mingze129 @alibuild